Skip to content

Ensure siteId of SipPeers are set on list #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

Ensure siteId of SipPeers are set on list #80

merged 1 commit into from
Mar 3, 2025

Conversation

feanor07
Copy link
Contributor

@feanor07 feanor07 commented Feb 28, 2025 •
edited
Loading

SipPeer get method is properly setting both siteId and client; but list is only setting client. If you happen to call delete for a sSipPeer retrieved via list, the delete endpoint url is not properly created due to missing siteId attribute. This PR fixes that.

@feanor07 feanor07 requested review from a team as code owners February 28, 2025 16:50
@ckoegel
Copy link
Contributor

ckoegel commented Mar 3, 2025

Thanks for the contribution @feanor07 !
I'll get this merged and we'll do a release with the fix tomorrow (March 4)

@ckoegel ckoegel merged commit c4a0280 into Bandwidth:main Mar 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckoegel ckoegel ckoegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feanor07 @ckoegel